search

SwapnilShahGit / SIP

This is a project that was created by the PEY Interns of the 2016-2017 year at SOTI. We created an organizational tool for students using the MEAN stack.
3 stars 0 forks source link

Implement search bar functionality #442

Open SwapnilShahGit opened 7 years ago

SwapnilShahGit commented 7 years ago

Currently does nothing: image

One possible idea for implementation: image

Edit by @hobindar: Made it clear that the second photo is only one possible option.

usoltsevpaul commented 7 years ago

@SwapnilShahGit wouldnt say this is a bug... Its to be expected.

We can do one of the following:

AdamNatale commented 7 years ago

Should we implement the search in this issue, we should have a discussion about implementation, but here's an idea for how we can approach this.

Currently, we have the contents of the side panel hard coded in main-page.component.html. We should first set up a component to hold it's contents, then create an enum with all possible tabs. We then dynamically display all items in the enum in the panel. The search bar component used on the panel would connect directly with this enum, and as the search string is updated, filter the currently displayed tabs based on the search string, with some kind of indication (ie bolded text). When the string is empty, display all options. Setting up this enum would prepare us for any kind of customization which needs to be done to the side panel, for example displaying a tab specifically for UofT students.

hobindar commented 7 years ago

Removing bug label as this isn't expected to be working yet. Rephrasing title for same reason.