Course API need fixing

[usoltsevpaul]

@pranR @hobindar @SwapnilShahGit Who ever can (if no one can I might do it sometime this weekend) found couple things while working with courses API. This currently blocks me from finish up the courses tab properly:

• Course delete API seems to always return 404 instead of 200. I.e it looks like it deletes the course (well actually deletes the link to the user) but it seems to return 404.
• Update SHOULD return the updated object as a whole, it seems to do what it likes and returns random stuff - most importantly it does not return courseId which I very much need. To reiterate please return the whole course object.
• Random stuff is STILL not returned as we discussed - Im guessing its just been forgotten, Exam related stuff is not returned. I.e the bool and string are not to be seen? Do they even get saved?
• Please update API accordingly...
• You can use my branch feat/534 to test some stuff if youd like, all 4 API are connected - some of which are buggy. Message me if you want more details.

@hobindar going back to isDraft, I told you about it how it changes the behaviour. To reiterate it does 2 things:

• Save button instead of Update button in UI - which calls save instead of update obviously.
• Delete button has different logic. If its a draft it just removes it from UI (its not in DB to my knowledge - THIS MAY BE PROBLEMATIC if you give me parsed and not saved course...) and that's it. If its not a draft then it will actually do the API delete call.

[hobindar]

Fuck... A back end bug. :(

Going to take a look at this now.

[hobindar]

@usoltsevpaul, a couple questions...

Random stuff is STILL not returned as we discussed - Im guessing its just been forgotten, Exam related stuff is not returned. I.e the bool and string are not to be seen? Do they even get saved?

Are you referring to examNotifications and examInfo?

Please update API accordingly...

According to above points?

If its a draft it just removes it from UI (its not in DB to my knowledge - THIS MAY BE PROBLEMATIC if you give me parsed and not saved course...) and that's it.

You're right, that would be fairly problematic. Does front end actually need to store isDraft in the db for how it's used in front end? If not, could we redefine isDraft to mean what you said but also that it's saved in db (i.e. is draft && is stored in db)?

I've fixed most of your other concerns on a local branch. However, I'll wait for the answers to the above questions in case they trigger any tightly coupled code changes. Assigning this to you in the meantime.

[usoltsevpaul]

@darren

• yes examNotifications and examInfo need to be saved/returned. (just like API says? I think)
• yes API needs to be read through and updated - also please specify is an input goes in to url or in to body last time this caused confusing costing me/other people ~2h
• so yea the delete logic in front end for isDraft would screw things up a little bit, I believe easiest solution is to have another variable like idk isParseDraft (you guys set it) and for example if it is isDraft then delete just removes from list (no API) and if it is isDraft and isParseDraft then it will do API call etc etc something like that. But for isDraft it is not actually useful for backend in any way (the way it works right now) since once you actually save that course then im always setting isDraft to false... obviously since its now been saved... does that make sense?
• or alternatively dont save isDraft and instead you guys save / i save isParseDraft which will be for parser output courses, and isDraft I will have only locally for my self to help with actual manual course entries.

[hobindar]

or alternatively dont save isDraft and instead you guys save / i save isParseDraft which will be for parser output courses, and isDraft I will have only locally for my self to help with actual manual course entries.

I like this option.