Closed usoltsevpaul closed 7 years ago
Fuck... A back end bug. :(
Going to take a look at this now.
@usoltsevpaul, a couple questions...
Random stuff is STILL not returned as we discussed - Im guessing its just been forgotten, Exam related stuff is not returned. I.e the bool and string are not to be seen? Do they even get saved?
Are you referring to examNotifications and examInfo?
Please update API accordingly...
According to above points?
If its a draft it just removes it from UI (its not in DB to my knowledge - THIS MAY BE PROBLEMATIC if you give me parsed and not saved course...) and that's it.
You're right, that would be fairly problematic. Does front end actually need to store isDraft in the db for how it's used in front end? If not, could we redefine isDraft to mean what you said but also that it's saved in db (i.e. is draft && is stored in db)?
I've fixed most of your other concerns on a local branch. However, I'll wait for the answers to the above questions in case they trigger any tightly coupled code changes. Assigning this to you in the meantime.
@darren
or alternatively dont save isDraft and instead you guys save / i save isParseDraft which will be for parser output courses, and isDraft I will have only locally for my self to help with actual manual course entries.
I like this option.
@pranR @hobindar @SwapnilShahGit Who ever can (if no one can I might do it sometime this weekend) found couple things while working with courses API. This currently blocks me from finish up the courses tab properly:
@hobindar going back to isDraft, I told you about it how it changes the behaviour. To reiterate it does 2 things: