search

SwaprHQ / swapr-dapp

DEX meta agregator
https://swapr.eth.limo/
GNU General Public License v3.0
49 stars 57 forks source link

[SWA-42][FEAT] - Add BiSwap as routable platform for BNB Chain #1831

Closed ElRodrigote closed 1 year ago

ElRodrigote commented 1 year ago

⚠️ Waiting for SDK updates to be released ⚠️

Fixes:

Description

image

How to test the changes

1) Pull this branch 2) Run the project locally 3) Go to Swapr landing page 4) Connect your wallet to BNB Chain 5) Any given swap should try to route through BiSwap as part of the BNB Chain routable platforms

netlify[bot] commented 1 year ago

Deploy Preview for swapr failed.

Name Link
Latest commit 49b422d0bc4aab8d685e69acce3c11e4e9338060
Latest deploy log https://app.netlify.com/sites/swapr/deploys/64761d30cb2da30008b65064
ElRodrigote commented 1 year ago

Code looks good to me. Is it me or the SVG looks a bit strange? Will approve after having a new SDK release.

Oh sorry, might the SVG look strange because I highlighted the changes with a yellow marker?

0xVenky commented 1 year ago

Looking good! Tested with a few swaps and routes through Biswap! :)

berteotti commented 1 year ago

@ElRodrigote don't forget to generate the new analytics please

ElRodrigote commented 1 year ago

@ElRodrigote don't forget to generate the new analytics please

Analytics added tho I have doubts about the command output, please if you could check if those values are ok would be awesome since I don't know how to do those checks yet

Also optimized BiSwap SVG logo

@NelsonGaldeman I reverted the SKD version and cleaned up the yarn.lock file changes