SwaprHQ / swapr-dapp

DEX meta agregator
https://swapr.eth.limo/
GNU General Public License v3.0
49 stars 57 forks source link

feat: add stackly popup #1835

Closed berteotti closed 1 year ago

berteotti commented 1 year ago

Fixes: #swa-62

Description

This PR adds stackly popup in yellow and green type. Advise to test it on preview link (or build it locally) then to test it locally, will fail to show the modal due to how react works locally.

To make it work don't forget to set env variables:

REACT_APP_STACKLY_POPUP_COLOR=yellow REACT_APP_SHOW_STACKLY_POPUP=true

image

How to test the changes

I advise to test it in the preview. Once you close the only way to see it again is through cleaning local storage.

netlify[bot] commented 1 year ago

Deploy Preview for swapr ready!

Name Link
Latest commit cfd96141487d17dd1040e2245b2599a6caefd3da
Latest deploy log https://app.netlify.com/sites/swapr/deploys/647724434cecfc0008b03050
Deploy Preview https://deploy-preview-1835--swapr.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

wixzi commented 1 year ago

The code works as expected. Good Job @berteotti . Have some minor suggestions on variable names. If you feel my suggestions are better then only change them.

0xVenky commented 1 year ago

Lookie good! Letsssgooo

Diogomartf commented 1 year ago

Looking good!