SwaprHQ / swapr-dapp

DEX meta agregator
https://swapr.eth.limo/
GNU General Public License v3.0
49 stars 57 forks source link

[SWA-30, 42 & 15][FEATS] - $ARB common token, BiSwap on BSC and zkSync Era support #1842

Closed ElRodrigote closed 1 year ago

ElRodrigote commented 1 year ago

Fixes:

Description

This PR merges the work pending for an SDK release from the following PRs:

netlify[bot] commented 1 year ago

Deploy Preview for swapr ready!

Name Link
Latest commit c34bd916bc84c4f77664051c0cd7590f349c4d4d
Latest deploy log https://app.netlify.com/sites/swapr/deploys/6499af92170798000817ee60
Deploy Preview https://deploy-preview-1842--swapr.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

berteotti commented 1 year ago

We can remove zksync testnet on select network list as it isn't important for our users.

NelsonGaldeman commented 1 year ago

I've tried the new zkSync Era tokenlist and most of the routes don't work because it's not supported by 1inch so even though we have some tokens now it's quite useless. If it's to hard to do a format convertion between 1inch format and our current tokenlist format, I would suggest to hardcode 1inch tokenlist for now. It's better than just showing a bunch of random tokens that can't be swaped.

ElRodrigote commented 1 year ago

I've tried the new zkSync Era tokenlist and most of the routes don't work because it's not supported by 1inch so even though we have some tokens now it's quite useless. If it's to hard to do a format convertion between 1inch format and our current tokenlist format, I would suggest to hardcode 1inch tokenlist for now. It's better than just showing a bunch of random tokens that can't be swaped.

Done!

NelsonGaldeman commented 1 year ago

LGTM, good job!