SwaprHQ / swapr-dapp

DEX meta agregator
https://swapr.eth.limo/
GNU General Public License v3.0
49 stars 57 forks source link

[SWA-129][FEAT] - Add Scroll chain support #1902

Closed ElRodrigote closed 7 months ago

ElRodrigote commented 7 months ago

Fixes: SWA-129

Description

Visual Evidence

image

How to test the changes

1) Pull this branch 2) Run the project locally 3) Go to Swapr dapp page 4) Connect your wallet 5) Connect to Scroll chain and try to check balances and/or do a swap. The token quotes should appear through Sushi v3

netlify[bot] commented 7 months ago

Deploy Preview for swapr ready!

Name Link
Latest commit 397da1d5865f7228ba1348f395f7c35d339d54f3
Latest deploy log https://app.netlify.com/sites/swapr/deploys/65bbf5c6cbac8d00088702af
Deploy Preview https://deploy-preview-1902--swapr.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 25 (no change from production)
Accessibility: 80 (no change from production)
Best Practices: 92 (no change from production)
SEO: 67 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Diogomartf commented 7 months ago
image

on the screenshot Sushiswap appear twice, that's not supposed right?

Diogomartf commented 7 months ago

Looks good but missing the preview link to test!

ElRodrigote commented 7 months ago
image

on the screenshot Sushiswap appear twice, that's not supposed right?

It's not supposed to I think, but somehow we're getting 2 "Sushitrade" objects in the all platforms array. I was thinking if filtering the list by pathcode or some way to identify each trade but couldn't manage to come up with a solution for that

Diogomartf commented 7 months ago
image

on the screenshot Sushiswap appear twice, that's not supposed right?

It's not supposed to I think, but somehow we're getting 2 "Sushitrade" objects in the all platforms array. I was thinking if filtering the list by pathcode or some way to identify each trade but couldn't manage to come up with a solution for that

That's odd, would be great to just have one for good UX.

ElRodrigote commented 7 months ago
image

on the screenshot Sushiswap appear twice, that's not supposed right?

It's not supposed to I think, but somehow we're getting 2 "Sushitrade" objects in the all platforms array. I was thinking if filtering the list by pathcode or some way to identify each trade but couldn't manage to come up with a solution for that

That's odd, would be great to just have one for good UX.

Seems to be working right now, apparently it was a duplicated response from the API