search

Swarchal / platetools

An R package for plotting microtitre plates
Other
54 stars 15 forks source link

R CMD check fails with dev testthat #19

Closed hadley closed 5 years ago

hadley commented 5 years ago

Because you have

test_that("missing_wells errors when expected",{
     expect_error(missing_wells(full, well = "well", plate = 1))
     expect_error(missing_wells(full, well = TRUE))
     expect_error(missing_wells(full, well = full$well))
     expect_error(missing_wells(as.list(full), well = full$well),
     expect_error(missing_wells(full, well = missing$wel)))
     expect_error(missing_wells(as.matrix(full), well = full$well))
     expect_error(missing_wells(fill, well = full$not_valid_col))
})

But I think you want:

test_that("missing_wells errors when expected",{
  expect_error(missing_wells(full, well = "well", plate = 1))
  expect_error(missing_wells(full, well = TRUE))
  expect_error(missing_wells(full, well = full$well))
  expect_error(missing_wells(as.list(full), well = full$well))
  expect_error(missing_wells(full, well = missing$wel))
  expect_error(missing_wells(as.matrix(full), well = full$well))
  expect_error(missing_wells(fill, well = full$not_valid_col))
})
hadley commented 5 years ago

Can you please submit an update to CRAN soon? I am aiming to submit testthat next week.

Swarchal commented 5 years ago

Yes I will try and submit it before Monday.