aaronmck commented 5 years ago

Thanks for the great tool! I just ran into a weird error, where platetools indicated I had too many wells for the plate I specified. This seemed a bit weird as I had just a few wells. It ended up being the second condition in the code below, which could use a better warning. You could drop my redundant warning text, but I like it being super clear to the user that this is a warning. Let me know what you think.

codecov[bot] commented 5 years ago

Codecov Report

Merging #21 into master will decrease coverage by 0.05%. The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   92.88%   92.83%   -0.06%     
==========================================
  Files          26       26              
  Lines         703      698       -5     
==========================================
- Hits          653      648       -5     
  Misses         50       50

Impacted Files	Coverage Δ
R/check_plate_input.R	`66.66% <50%> (ø)`	:arrow_up:
R/b_grid.R	`95.23% <0%> (-0.42%)`	:arrow_down:
R/med_smooth.R	`96.15% <0%> (-0.08%)`	:arrow_down:
R/plate_map.R	`100% <0%> (ø)`	:arrow_up:
R/set_block.R	`100% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c16cff1...9b065f7. Read the comment docs.

Swarchal commented 5 years ago

Good catch and thanks for the pull request.

Swarchal / platetools

Simple warning message change #21

Codecov Report