Swarchal / platetools

An R package for plotting microtitre plates
Other
54 stars 15 forks source link

Axis labels and title rendering is broken with recent ggplot2 version #22

Closed shntnu closed 4 years ago

shntnu commented 4 years ago

The rendering seems to be broken with the recent version of ggplot2.

PS – Thank you for this package!

library(platetools)
library(ggplot2)
library(viridis)
#> Loading required package: viridisLite

df <- data.frame(vals = rnorm(384),
                 well = num_to_well(1:384, plate = 384))

raw_map(data = df$vals,
        well = df$well,
        plate = 384) +
  ggtitle("Example 384-well plate") +
  theme_dark() +
  scale_fill_viridis()

Created on 2020-05-01 by the reprex package (v0.3.0)

Session info ``` r devtools::session_info() #> ─ Session info ─────────────────────────────────────────────────────────────── #> setting value #> version R version 3.6.3 (2020-02-29) #> os macOS Mojave 10.14.6 #> system x86_64, darwin15.6.0 #> ui X11 #> language (EN) #> collate en_US.UTF-8 #> ctype en_US.UTF-8 #> tz America/New_York #> date 2020-05-01 #> #> ─ Packages ─────────────────────────────────────────────────────────────────── #> package * version date lib source #> assertthat 0.2.1 2019-03-21 [1] CRAN (R 3.6.0) #> backports 1.1.6 2020-04-05 [1] CRAN (R 3.6.2) #> callr 3.4.3 2020-03-28 [1] CRAN (R 3.6.3) #> cli 2.0.2 2020-02-28 [1] CRAN (R 3.6.0) #> colorspace 1.4-1 2019-03-18 [1] CRAN (R 3.6.0) #> crayon 1.3.4 2017-09-16 [1] CRAN (R 3.6.0) #> curl 4.3 2019-12-02 [1] CRAN (R 3.6.0) #> desc 1.2.0 2018-05-01 [1] CRAN (R 3.6.0) #> devtools 2.3.0 2020-04-10 [1] CRAN (R 3.6.2) #> digest 0.6.25 2020-02-23 [1] CRAN (R 3.6.0) #> dplyr 0.8.5 2020-03-07 [1] CRAN (R 3.6.0) #> ellipsis 0.3.0 2019-09-20 [1] CRAN (R 3.6.0) #> evaluate 0.14 2019-05-28 [1] CRAN (R 3.6.0) #> fansi 0.4.1 2020-01-08 [1] CRAN (R 3.6.0) #> farver 2.0.3 2020-01-16 [1] CRAN (R 3.6.0) #> fs 1.3.2 2020-03-05 [1] CRAN (R 3.6.0) #> ggplot2 * 3.3.0 2020-03-05 [1] CRAN (R 3.6.0) #> glue 1.4.0 2020-04-03 [1] CRAN (R 3.6.2) #> gridExtra 2.3 2017-09-09 [1] CRAN (R 3.6.0) #> gtable 0.3.0 2019-03-25 [1] CRAN (R 3.6.0) #> highr 0.8 2019-03-20 [1] CRAN (R 3.6.0) #> htmltools 0.4.0 2019-10-04 [1] CRAN (R 3.6.0) #> httr 1.4.1 2019-08-05 [1] CRAN (R 3.6.0) #> knitr 1.28 2020-02-06 [1] CRAN (R 3.6.0) #> labeling 0.3 2014-08-23 [1] CRAN (R 3.6.0) #> lifecycle 0.2.0 2020-03-06 [1] CRAN (R 3.6.0) #> magrittr 1.5 2014-11-22 [1] CRAN (R 3.6.0) #> memoise 1.1.0 2017-04-21 [1] CRAN (R 3.6.0) #> mime 0.9 2020-02-04 [1] CRAN (R 3.6.0) #> munsell 0.5.0 2018-06-12 [1] CRAN (R 3.6.0) #> pillar 1.4.3 2019-12-20 [1] CRAN (R 3.6.0) #> pkgbuild 1.0.7 2020-04-25 [1] CRAN (R 3.6.2) #> pkgconfig 2.0.3 2019-09-22 [1] CRAN (R 3.6.0) #> pkgload 1.0.2 2018-10-29 [1] CRAN (R 3.6.0) #> platetools * 0.1.2 2019-04-24 [1] CRAN (R 3.6.0) #> prettyunits 1.1.1 2020-01-24 [1] CRAN (R 3.6.0) #> processx 3.4.2 2020-02-09 [1] CRAN (R 3.6.0) #> ps 1.3.2 2020-02-13 [1] CRAN (R 3.6.0) #> purrr 0.3.4 2020-04-17 [1] CRAN (R 3.6.2) #> R6 2.4.1 2019-11-12 [1] CRAN (R 3.6.0) #> RColorBrewer 1.1-2 2014-12-07 [1] CRAN (R 3.6.0) #> Rcpp 1.0.4 2020-03-17 [1] CRAN (R 3.6.0) #> remotes 2.1.1 2020-02-15 [1] CRAN (R 3.6.0) #> rlang 0.4.5 2020-03-01 [1] CRAN (R 3.6.0) #> rmarkdown 2.1 2020-01-20 [1] CRAN (R 3.6.0) #> rprojroot 1.3-2 2018-01-03 [1] CRAN (R 3.6.0) #> scales 1.1.0 2019-11-18 [1] CRAN (R 3.6.0) #> sessioninfo 1.1.1 2018-11-05 [1] CRAN (R 3.6.0) #> stringi 1.4.6 2020-02-17 [1] CRAN (R 3.6.0) #> stringr 1.4.0 2019-02-10 [1] CRAN (R 3.6.0) #> testthat 2.3.2 2020-03-02 [1] CRAN (R 3.6.0) #> tibble 3.0.1 2020-04-20 [1] CRAN (R 3.6.2) #> tidyselect 1.0.0 2020-01-27 [1] CRAN (R 3.6.0) #> usethis 1.6.1 2020-04-29 [1] CRAN (R 3.6.3) #> vctrs 0.2.4 2020-03-10 [1] CRAN (R 3.6.0) #> viridis * 0.5.1 2018-03-29 [1] CRAN (R 3.6.0) #> viridisLite * 0.3.0 2018-02-01 [1] CRAN (R 3.6.0) #> withr 2.2.0 2020-04-20 [1] CRAN (R 3.6.2) #> xfun 0.13 2020-04-13 [1] CRAN (R 3.6.2) #> xml2 1.3.2 2020-04-23 [1] CRAN (R 3.6.2) #> yaml 2.2.1 2020-02-01 [1] CRAN (R 3.6.0) #> #> [1] /Library/Frameworks/R.framework/Versions/3.6/Resources/library ```
Swarchal commented 4 years ago

Thanks for this. It looks like the behaviour of the ylim argument in coord_fixed has been reversed when used with scale_y_reverse in the latest ggplot version.

There's a quick fix in the ylim_fix branch if you need something working urgently. I'll get something working across multiple ggplot2 versions and send it to CRAN.