Closed fdchevalier closed 3 years ago
Hi Fred,
This seems like a good idea. I'll admit I never actually tested it with the clear background.
Hi @fdchevalier , you should be able to adjust the size, colour and transparency of missing wells. This is available in the github master branch. It won't be on CRAN yet.
The plot functions now have the additional arguments na_fill
, na_alpha
and na_size_ratio
.
e.g
library(platetools)
df <- data.frame(val = rnorm(96), well = num_to_well(1:96))
df_partial <- dplyr::sample_frac(df, 0.7)
raw_map(
df_partial$val,
df_partial$well,
na_fill = "grey",
na_size_ratio = 1,
na_alpha = 1
)
Hi Scott,
Thank you very much for having implemented this! Exactly what I needed. No worries if it is not yet on CRAN. However, do you have any idea when you will release the next version?
Anyway, this can be considered a solved issue.
Fred
Glad to help. I will probably submit the current master branch to CRAN in the next week or so.
Hello Scott,
First thank you for developing this very helpful package!
While using it, I discovered that missing wells are not very visible on clear background compared to dark background. After inspecting the code, I propose to introduce an argument like
na.fill
to theplt.()
functions. This will allow the user to specify what fill color to use for missing wells. The border color can then specifically be adjusted using theadjustcolor()
from the grDevices package (or ana.border
argument could also be made).On the same line, I found that the size of the missing wells too small. Introducing a
na.size
argument the same way would help. I would also suggest to make it proportionally relative to the the size of the non-missing well.Here is how the function would look like:
This argument will need to be added to the
raw_map()
function I guess. If you need help on this, I can implement it.Thank you,
Fred