kkovary commented 3 years ago

The function is_1536 failed to recognize 1536 well plates when column numbers weren't zero padded (i.e. A1 vs A01). This is because it was checking if the number of characters in the vector of wells was equal to 4, which it wouldn't be in the case where column numbers aren't zero padded (AA1 vs AA01). This change looks for wells that contain two consecutive letters.

codecov[bot] commented 3 years ago

Codecov Report

Merging #28 (9861b86) into master (2d37660) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   91.48%   91.49%           
=======================================
  Files          26       26           
  Lines         881      882    +1     
=======================================
+ Hits          806      807    +1     
  Misses         75       75

Impacted Files	Coverage Δ
R/plate_map.R	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d37660...9861b86. Read the comment docs.

Swarchal commented 3 years ago

Thanks @kkovary

Swarchal / platetools

Fix for is_1538 #28

Codecov Report