search

Swarchal / platetools

An R package for plotting microtitre plates
Other
54 stars 15 forks source link

Update test expectations #36

Closed teunbrand closed 7 months ago

teunbrand commented 9 months ago

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break platetools.

Briefly, a few tests expected ggplot objects to satisfy some length and name criterions that no longer hold in the new version. In this PR, these are updated to be aligned with whatever ggplot() returns, which works for both the old and new versions.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in https://github.com/tidyverse/ggplot2/issues/5588. We hope that this PR might help platetools get out a fix if necessary.

teunbrand commented 8 months ago

This is just a reminder that the release of ggplot2 is scheduled soon.