search

Swarnendu0123 / adopt-pet

A Blockchain Based pet adopting platform.
MIT License
5 stars 11 forks source link

Added struct for pet, modified contract functions #2

Closed ShivRaiGithub closed 1 month ago

ShivRaiGithub commented 1 month ago

Fixes #1 Added a new struct of Pet to better define the kind of pet, modified functions accordingly, added a new function to get unadopted pets, made some other modifications for better security and gas optimizations.

ShivRaiGithub commented 1 month ago

The contract was tested on remix for quick test of all functions. For hardhat test, a new pr can be made.

ShivRaiGithub commented 1 month ago

Overall did it worked with the reach app? if yes attach a screenshot or video of the UI.

I haven't integrated the changes with the frontend yet, I would if this pr is accepted because since it is dealing with the contract itself, any change would have to be implemented for the frontend again. The frontend is still able to render though.

Swarnendu0123 commented 1 month ago

Overall did it worked with the reach app? if yes attach a screenshot or video of the UI.

I haven't integrated the changes with the frontend yet, I would if this pr is accepted because since it is dealing with the contract itself, any change would have to be implemented for the frontend again. The frontend is still able to render though.

Well, I don't think so. I think the contract and the frontend should be in sync, so do the changes which are required. Don't take stress about the labels and all, these things are for learning only.

ShivRaiGithub commented 1 month ago

Ok sure, will create a new PR with the frontend integrated too. However, please take care of the labels since it was told by a mentor in wob discord that contributions will be counted through labels. Thank you.

Swarnendu0123 commented 1 month ago

Ok sure, will create a new PR with the frontend integrated too. However, please take care of the labels since it was told by a mentor in wob discord that contributions will be counted through labels. Thank you.

Sorry, I can't merge any PR before I ensure it end to end working. Otherwise the project will go unstructured, I don't want that.

ShivRaiGithub commented 1 month ago

Ok sure, will create a new PR with the frontend integrated too. However, please take care of the labels since it was told by a mentor in wob discord that contributions will be counted through labels. Thank you.

Sorry, I can't merge any PR before I ensure it end to end working. Otherwise the project will go unstructured, I don't want that.

Yes, I meant a new pr including the frontend and contract changes. This one can be closed.