Swartdogs / PowerScout

Scouting App for FRC Power Up
Apache License 2.0
1 stars 0 forks source link

Change Picker View Closing Triggers #37

Closed pr1sm closed 6 years ago

pr1sm commented 6 years ago

The Picker views for the Starting Position and End game climbing position are triggered by a button to show and then hide when a different value is selected. However, if the button is tapped, the picker view will remain on the screen until the value is changed. This is inconsistent behavior and these picker views should be closed in the following cases:

To detect when the background is tapped, see the TeamInfoViewController for an example of how to add a gesture recognizer.

pr1sm commented 6 years ago

It might be better to use a control scheme similar to how it is displayed here: https://developer.apple.com/ios/human-interface-guidelines/controls/pickers/

Instead of having the picker appear below in the same view controller, it can appear on the bottom similar to a keyboard. This will not affect view hierarchy like it currently does, but will instead prompt users to make changes. A done button can be added to this "keyboard" to manually dismiss the picker view as well.

pr1sm commented 6 years ago

49 has the same idea, closing this in favor of that