Add 404 not found page. - Githubissues

Swastikyadav / hacker-stories

A news site using hacker news API. View new and best tech stories.

https://hackerstory.netlify.app/

8 stars 6 forks source link

Add 404 not found page. #10

Open Swastikyadav opened 2 years ago

Swastikyadav commented 2 years ago

Use react-router-dom for routing.
Capture invalid routes and show 404 not found page.
On 404 page, just download and add the following svg.

hs_page_not_found

Tusharjain123 commented 2 years ago

Hey @Swastikyadav Can I work on this issue?

DugarRishab commented 2 years ago

Hey, @Swastikyadav I would like to contribute to this.

Swastikyadav commented 2 years ago

Hey @Swastikyadav Can I work on this issue?

Hi @Tusharjain123

Thanks for showing your interest. This issue is now assigned to you. Please fork the repo, make the changes in your branch and raise PR (pull request) against the master branch of this repo.

Swastikyadav commented 2 years ago

Hey, @Swastikyadav I would like to contribute to this.

Hi @DugarRishab,

I really appreciate your interest. But this one goes to Tushar, as he approached first. May you look into other issue please.

Thanks!