collapsable tiers - Githubissues

SwatPhonLab / UltraTrace

A Free/Open-Source tool for manual annotation of Ultrasound Tongue Imaging data.

GNU General Public License v3.0

10 stars 5 forks source link

collapsable tiers #51

Open mr-martian opened 5 years ago

mr-martian commented 5 years ago

Originally posted by @jonorthwash at 2019-05-17T20:02:20Z (original issue)

Tiers should all start at ~⅕ of their current height, with no text. They should be expandable (and it should remember expanded/collapsed status for the remainder of the session) to look how they are now. The controls can be down/up arrow next to tier names, and also scrollwheel on the tier.

mr-martian commented 5 years ago

Originally posted by @mr-martian at 2019-10-16T23:13:36Z

Double clicking on the tier label will now toggle the height between 60px (default) and 15px. Issues:

Collapsing and then expanding can cause some of the trace control buttons to get covered up
Tier labels disappear because I didn't work out how to properly reposition the text
Doesn't work on frames tier

mr-martian commented 5 years ago

Originally posted by @jonorthwash at 2019-10-17T03:23:59Z

I wonder if scroll-down (for collapse) and scroll-up (for expand) events on the tiers themselves could also be tied to this.

mr-martian commented 5 years ago

Originally posted by @jonorthwash at 2019-10-17T03:29:53Z

I think one of the issues in repositioning the text is that it has too much padding, just like the text in the tiers, cf. some of the things in #53.

mr-martian commented 5 years ago

Originally posted by @mr-martian at 2019-10-17T14:06:35Z

I bound it to double click just so there would be a binding. It is now also bound to scroll.

I also added a slightly ugly solution to get the tier names to display when collapsed (or, it wasn't ugly, but then I found myself manually shifting the text by 7 pixels...).

mr-martian commented 5 years ago

Originally posted by @jonorthwash at 2019-10-17T14:39:48Z

I bound it to double click just so there would be a binding. It is now also bound to scroll.

I meant scroll on the tiers themselves, not [just] the labels.

I also added a slightly ugly solution to get the tier names to display when collapsed (or, it wasn't ugly, but then I found myself manually shifting the text by 7 pixels...).

It looks nice here. I wonder if it renders the same on Mac or with different themes.

mr-martian commented 5 years ago

Originally posted by @mr-martian at 2019-10-18T22:01:02Z

I meant scroll on the tiers themselves, not [just] the labels.

Done, though scroll up on collapsed tiers is a little tricky

mr-martian commented 5 years ago

Originally posted by @mr-martian at 2019-10-20T20:46:22Z

Text positioning looks fine on Mac, but the bindings for scrolling don't seem to be working (<Button-4> and <MouseWheel> both have no effect).

mr-martian commented 5 years ago

Originally posted by @jonorthwash at 2019-10-21T05:29:45Z

Yeah, I think scroll issues on Mac are generally a larger tkinter bug.

mr-martian commented 5 years ago

Originally posted by @jonorthwash at 2019-11-02T03:39:29Z

I think the main things remaining for this issue are:

all tiers should start in collapsed mode by default
tiers either shouldn't have text (but have some mechanism showing that they aren't empty?) or should show as much text as will fit (if any) and then "..."?
it should be checked whether expanded/collapsed status is remembered for the remainder of the session
there seems to be an issue where it sometimes gets into a state where scrollwheel on any tier only collapses the top one. I'm having trouble reproducing it, but I'll keep my eye out for it and can report it as a separate issue if needed.