Swati4star / Images-to-PDF

An app to convert images to PDF file!

GNU General Public License v3.0

1.22k stars 812 forks source link

[#1101]Add a features: Scan QR code from saved picture #1138

Closed u7505884 closed 1 year ago

u7505884 commented 1 year ago

Description

Fixes: The issue poster said that when tapping the scan qr code button there is no "select image" option, nothing but only the camera waiting to see a qr code, so I added the "Scan from the saved image" button. Users can select the images they want to scan from the album.

If there are no images in the album,

If there are images, but no QR code on it

Fixes #1101

Type of change

Just put an x in the [] which are valid.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

[x] ./gradlew assembleDebug assembleRelease
[x] ./gradlew checkstyle

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 07c234ae and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	2

View more on Code Climate.

Swati4star commented 1 year ago

thank you for your contribution, but this feature is already implemented with https://github.com/Swati4star/Images-to-PDF/pull/1143