Swati4star / Images-to-PDF

An app to convert images to PDF file!
GNU General Public License v3.0
1.17k stars 790 forks source link

[#1103,duplicated PR] Added the jpg output format as apart of the PNG, improve for compatibility #1148

Closed Gary709 closed 8 months ago

Gary709 commented 8 months ago

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change. Add a new JPG output format which suits for devices that do not support PNG Users can self-select their preferred format Here's a demo video https://github.com/Swati4star/Images-to-PDF/assets/97233980/953a7d3d-7365-4338-8540-2a01b1211cfe

video demo

Type of change

Just put an x in the [] which are valid.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. The demo video shows that when PDF is converted to image, it will generate both PNG and JPG files.

Screenshot 2023-10-28 at 1 47 37 pm Screenshot 2023-10-28 at 1 47 31 pm

Checklist:

codeclimate[bot] commented 8 months ago

Code Climate has analyzed commit 596a4372 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

Gary709 commented 8 months ago

Okay, I will fixed the complexity error

Gary709 commented 8 months ago

Fixed complexity error, added JavaDoc, comments. etc