UI improvement

[kranthivakati]

Steps to reproduce

1.install the app from the playstore. 2.open the app & upload a photo which can be convert into pdf. 3.after uploading a photo click on FIlter images. 4.after clicking on Filter images we are navigating into that particular page in the left top Reset button doesn't displaying properly .

Expected behaviour

Reset button should be similar like save button

Actual behaviour

reset , save button which are in different type of buttons.

Would you like to work on the issue?

this is the low priority issue but this is major defect because user can see this bug and can say this app is not good.

[PaulBerger56]

I would like to work on this issue. I also sent an email to the address listed. I believe changing the width of the button should fix it and I can test it on several virtual devices on android studio to make sure screen size and shape does not affect the text.

[PaulBerger56]

I was able to fix the button's width to accomodate the text with the appropriate padding. I did have to reduce the width of the ImageCount box because the next image arrow was not visible on smaller devices after resizing the Reset button.

I will wait to hear back before putting in a pull request, but I have uploaded some screenshots of the virtual devices running on my end.

Pixel Fold Open

Pixel Fold Closed

Small Android Phone

[kranthivakati]

Wait let me check from my end can you tell me how to install latest version in device. i'm using playstore version.

On Wed, 7 Aug, 2024, 4:27 pm PaulB, @.***> wrote:

I was able to fix the button's width to accomodate the text with the appropriate padding. I did have to reduce the width of the ImageCount box because the next image arrow was not visible on smaller devices after resizing the Reset button.

I will wait to hear back before putting in a pull request, but I have uploaded some screenshots of the virtual devices running on my end. Pixel Fold Open

Pixel.Fold.Open.png (view on web) https://github.com/user-attachments/assets/1ea9e14d-05a2-4be3-9fa3-3617a7f85409 Pixel Fold Closed

Pixel.Fold.Closed.png (view on web) https://github.com/user-attachments/assets/9ec80898-4052-48eb-bb41-fead6a21a2c0 Small Android Phone

Small.Phone.png (view on web) https://github.com/user-attachments/assets/12f17216-084e-428e-a9ff-1afd02fc5d7b

— Reply to this email directly, view it on GitHub https://github.com/Swati4star/Images-to-PDF/issues/1169#issuecomment-2273193745, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5OR3LNYXYXW5GLOZYCORMTZQH4PXAVCNFSM6AAAAABL647SS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZTGE4TGNZUGU . You are receiving this because you authored the thread.Message ID: @.***>

[kranthivakati]

@PaulBerger56 good job can you help me that where i can install latest build so that i can close this issue from my end

[PaulBerger56]

@kranthivakati Hey, I am a contributor, but do not own the project myself. I did a pull request with my fix, but it is up to the owner of the repository if they want to add it or not. If you are able to set this ticket back to open, I would do that and not close it until the repository owner updates the codebase.

[kranthivakati]

Thanks, I'll look into it.

On Wed, 7 Aug, 2024, 8:05 pm PaulB, @.***> wrote:

@kranthivakati https://github.com/kranthivakati Hey, I am a contributor, but do not own the project myself. I did a pull request with my fix, but it is up to the owner of the repository if they want to add it or not. If you are able to set this ticket back to open, I would do that and not close it until the repository owner updates the codebase.

— Reply to this email directly, view it on GitHub https://github.com/Swati4star/Images-to-PDF/issues/1169#issuecomment-2273629713, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5OR3LJYXRNPZFSOIPNR3IDZQIWDZAVCNFSM6AAAAABL647SS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZTGYZDSNZRGM . You are receiving this because you were mentioned.Message ID: @.***>