Closed kchugalinskiy closed 6 years ago
Hi @kchugalinskiy. Thanks for your proposal and it would be a great addition.
Before accepting this PR, could you:
gofmt
to respect the code formatingREADME.md
and mention the fact that the env var RECEIVER
becomes optionalSounds reasonable. I've fulfilled your requirements. Please take a look. Also I've added one error check _, err := jsonparser.ArrayEach() ... log.Warn(err)
and removed false comparation here: !ctx.IsPost()
instead of ctx.IsPost() == false
👍
We need a way to make phone call to a different people and it depends on prometheus event. I see no motivation to run a separated promtotwilio for each person we should call.
This pull request makes
RECEIVER
env var optional, adding areceiver
query parameter. If none is set, BadRequest should be returned.