search

SwedbankPay / kramdown-plantuml

PlantUML support for Kramdown, the Markdown parser used in Jekyll
https://rubygems.org/gems/kramdown-plantuml
Apache License 2.0
8 stars 2 forks source link

DX-914: Jekyll discovery #69

Closed asbjornu closed 3 years ago

asbjornu commented 3 years ago

Discover Jekyll and inject into its event hooks to fix the problem of the PlantUML theme file not being written to disk before kramdown-plantuml is invoked.

codecov[bot] commented 3 years ago

Codecov Report

Merging #69 (c24c213) into main (02c1ac1) will decrease coverage by 2.99%. The diff coverage is 78.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   96.66%   93.67%   -3.00%     
==========================================
  Files           9       10       +1     
  Lines         270      316      +46     
==========================================
+ Hits          261      296      +35     
- Misses          9       20      +11
Impacted Files Coverage Δ
lib/kramdown-plantuml/jekyll_provider.rb 62.50% <62.50%> (ø)
lib/kramdown-plantuml/diagram.rb 100.00% <100.00%> (ø)
lib/kramdown-plantuml/executor.rb 100.00% <100.00%> (ø)
lib/kramdown-plantuml/logger.rb 100.00% <100.00%> (+2.22%) :arrow_up:
lib/kramdown-plantuml/plantuml_result.rb 100.00% <100.00%> (+5.55%) :arrow_up:
lib/kramdown-plantuml/theme.rb 97.56% <100.00%> (ø)
lib/kramdown_html.rb 100.00% <100.00%> (ø)
lib/kramdown-plantuml/console_logger.rb 88.88% <0.00%> (+3.70%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02c1ac1...c24c213. Read the comment docs.

mergify[bot] commented 3 years ago

Thank you @asbjornu for your contribution!