SwedbankPay / kramdown-plantuml

PlantUML support for Kramdown, the Markdown parser used in Jekyll
https://rubygems.org/gems/kramdown-plantuml
Apache License 2.0
8 stars 2 forks source link

DX-914: Don't set `:site_destination_dir` #75

Closed asbjornu closed 2 years ago

asbjornu commented 2 years ago

Setting :site_destination_dir here may cause the following error if the options_hash is nil:

undefined method `[]=' for nil:NilClass (NoMethodError)
codecov[bot] commented 2 years ago

Codecov Report

Merging #75 (61524d6) into main (b92939b) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head 61524d6 differs from pull request most recent head 550ff71. Consider uploading reports for the commit 550ff71 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   94.03%   94.01%   -0.02%     
==========================================
  Files          12       12              
  Lines         419      418       -1     
==========================================
- Hits          394      393       -1     
  Misses         25       25              
Impacted Files Coverage Δ
lib/kramdown-plantuml/jekyll_provider.rb 86.11% <ø> (-0.20%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b92939b...550ff71. Read the comment docs.

mergify[bot] commented 2 years ago

Thank you @asbjornu for your contribution!