Sweenus / SimplySkills

Other
9 stars 15 forks source link

[Suggestion] Nameplate "Mob level" compatibility with DAS #83

Open muon-rw opened 2 months ago

muon-rw commented 2 months ago

Nameplate has a neat feature for inter-mod compatibility that allows any mod which scales a mob to affect its "level," however it looks like DAS-scaled mobs do not receive this treatment. The problem (I believe) is that this is calculated when the entity is loaded by a player, but Simply Skills' attribute scaling happens afterward, and the level does not update dynamically.

Maybe you could optionally call Nameplate's startTracking after attribute adjustments are applied? I'm not sure if this might be a performance concern, as this would also entail writing more NBT and sending another S2C packet for every DAS tick.