SwellRT / swellrt

SwellRT main project. Server, JavaScript and Java clients
http://swellrt.org/
Apache License 2.0
234 stars 34 forks source link

id postfix in open #241

Open Ana06 opened 6 years ago

Ana06 commented 6 years ago

From Reference.md:

  service.open({

      id : "local.net/s+T6Ad2s2TC2A"

  }).then( object => {

  })
  .catch( error => { ... });

Object will be created with an autogenerated id, if no id argument is provided. Optionally, a "prefix" can be passed to use in the autogenerated id.

Isn't it a postfix and not a prefix? :confused: I find the name of the variable id confusing... what about id_postfix? It would make much more clear what this is doing. At the moment without readong the documentation I would think that it is the actual id and not a postfix :thinking: Can we change this kind of things? I mean I think that if only JetPad is using this, then it is fine to change this kind of things :smile: