search

Swen670Grp1 / cytoscape-platform-tests-js

Reveal.js testing webapp for running platform tests on Cytoscape via CyREST calls
http://chianti.ucsd.edu/~bsettle/cytoscape_platform_test
MIT License
0 stars 0 forks source link

Feature/us 1 9 #44

Closed kouissar closed 5 years ago

kouissar commented 5 years ago

Please note this commit is for US 1.4. Commit for US 1.9 is coming soon.

kouissar commented 5 years ago

Got it. It makes sense, I will go ahead and implement it. Thanks

On Fri, Nov 23, 2018 at 9:36 AM skatulich notifications@github.com wrote:

@skatulich commented on this pull request.

So I like this but there needs to be a way to clear it. If our message tells the user to check the log for details, then when they click the log button the error should clear. Or we could have this be an alert with buttons and force the user to acknowledge the alert.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Swen670Grp1/cytoscape-platform-tests-js/pull/44#pullrequestreview-177948881, or mute the thread https://github.com/notifications/unsubscribe-auth/AIdYRaRE4wtLMW4Ozy1Qebw33Bco9O_Cks5uyAfwgaJpZM4Yus3n .

-- Thanks Rafik

kouissar commented 5 years ago

Added ability to acknowledge the error and clear the display. I will clean up the display once bootstrap changes from Steve branch are merged

kouissar commented 5 years ago

that's a leftover from my earlier debugging. I will clean that up on my final version

On Sat, Nov 24, 2018 at 4:01 PM rpaudyal4769 notifications@github.com wrote:

@rpaudyal4769 approved this pull request.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Swen670Grp1/cytoscape-platform-tests-js/pull/44#pullrequestreview-178062162, or mute the thread https://github.com/notifications/unsubscribe-auth/AIdYRfwfRngrLdK7mz9jJDF4a9v7HJbsks5uybOVgaJpZM4Yus3n .

-- Thanks Rafik