Target FSharp.Core 4.6.2 and catch up on support for new quotations

stephen-swensen commented 5 years ago

Build related

[x] Upgrade all projects to target FSharp.Core 4.6.2 while continuing to target .NET 4.5 and NetStandard 2.0 (see if possible to not make FSharp.Core 4.6.2 dependency in the distributed .NET 4.5 package)
[x] Drop support for NUnit v1, Xunit v1, Mbunit v3, and Fuchu... these are all long deprecated (more or less) testing frameworks
[x] NUnit 3.12.0 no longer produces clean stack trace (via the VerifyNunit3Support project) - it appears NUnit introduced some behavior, perhaps in https://github.com/nunit/nunit/pull/2700, that records the stack trace at the point of Assert.Fail being called, thus making it impractical for us provide a clean stack trace.
[x] Upgrade VerifyXunit2Support project to latest xunit version (tests no longer register in test explorer after doing this) - was able to do this for NetCore, but not net45 - perhaps will "fix itself" in a future version and we can try again.
[x] Make sure tests run in Release mode (they run fine in Debug mode, but are crashing with StackOverflowException somewhere in release mode in the .NET 4.5 build) (this seems to be a VS Test Explorer and / or xunit issue - running testing modules individually works fine)

Feature fixes

[x] Fix broken decompilation and reduction of literal range expressions (op_Range); it appears the representation for these has changed over since FSharp.Core 4.1... if possible, do in a backwards compatible way
[x] Address "This construct is deprecated. Please use QuoteTyped or QuoteRaw to distinguish between typed and raw quotation literals" warnings
[x] ~~Fix broken "@" symbol in function names like top@level~~ WONT FIX
[x] https://github.com/SwensenSoftware/unquote/issues/140 - missing stack trace?

New features

[x] https://github.com/SwensenSoftware/unquote/issues/133 - Support ValueWithName decompilation and reduction to Value
[x] https://github.com/SwensenSoftware/unquote/issues/142 - Support WithValue expressions
[x] Implement testSimple which only outputs the head expression (an option to reduce noise, especially from large object graphs)
[x] https://github.com/SwensenSoftware/unquote/issues/110 - Support NewRecord decompilation

Other Issues

thinkbeforecoding commented 5 years ago

Is there more work to do on this ?

stephen-swensen commented 5 years ago

@thinkbeforecoding yeah I want to at least look into the remaining "Build related" checklist items

SwensenSoftware / unquote