search

SwiftAndroid / swift

Port of Apple's reference Swift toolchain to Android; doesn't quite work yet
Apache License 2.0
720 stars 32 forks source link

libicu data files need to be pushed to device #19

Closed zhuowei closed 8 years ago

zhuowei commented 8 years ago

@modocache I don't think the build script pushes libicu yet; should that be added to the build script? I was getting "Illegal instruction" errors which turned out to be an abort() called by the runtime since libicu was missing.

modocache commented 8 years ago

Yes, it's possible that my device had those installed already from some other experiment. Scary! I'll add it to utils/android/adb_push_built_products and try to test a clean install more often. Thanks for pointing this out!!

modocache commented 8 years ago

This has been taken care of upstream: https://github.com/apple/swift/blob/60a6522ac6e618aca664bcf68f2d56cfa9ed3192/test/CMakeLists.txt#L234-L238

Thanks for pointing this out!!