Fix document manipulation

SwiftDocOrg / CommonMark

Create, parse, and render Markdown text according to the CommonMark specification

MIT License

179 stars 10 forks source link

Fix document manipulation #10

Closed Lukas-Stuehrk closed 4 years ago

Lukas-Stuehrk commented 4 years ago

Fixes #9

I'm not entirely happy with the mismatch of sibling now. Our sibling is exactly the other node than cmark's sibling. But I did not want to break the existing public API.

mattt commented 4 years ago

Gut gemacht, @Lukas-Stuehrk! My only feedback had to do with some annoying quirks of English spelling. If nothing else, it was an excuse to do a batched commit of PR suggestions, which worked great.

But seriously, kudos for writing some truly excellent tests. And thanks so much for identifying and fixing this issue in the first place. I'm sorry that I missed that cue from cmark's API and neglected to exercise that functionality entirely. Very happy to have this in here now, though.

Lukas-Stuehrk commented 4 years ago

You're welcome! It was a little bit too late in the evening to proofread English spelling 😴

And I did not know PR suggestions! So thank you for applying, I know a great tool now which I can utilize in the future.