search

SwiftDocOrg / GraphViz

A Swift package for working with GraphViz
MIT License
291 stars 32 forks source link

Add more Node Shapes cases #7

Closed natanrolnik closed 3 years ago

natanrolnik commented 4 years ago

This PR adds a few shapes that weren't yet declared in the Node.Shape enum, as box3d, cylinder, rectangle, and a few more.

In this link one can see more types, I added the ones which I found more interesting and weren't available yet here.

Tuist has a very interesting graph command, which can draw the dependency graph of an Xcode project or workspace. Having different types of shapes like a box and cylinder helps differentiate the different types of targets (App, App Extension, Swift Package, or frameworks, and others) and better understand the dependency tree. We are also using the commits from #6 , so thanks for your fix, @fwcd !

mattt commented 3 years ago

Thanks for the PR, @natanrolnik. And thanks for your patience in getting this reviewed and merged. This will be part of the forthcoming 0.2.0 release.

natanrolnik commented 3 years ago

Thanks, @mattt !