search

SwiftGen / StencilSwiftKit

A framework bringing additional nodes & filters to Stencil dedicated to Swift code generation
MIT License
296 stars 58 forks source link

CHANGELOG: Add missing bug fix entry #131

Closed AliSoftware closed 3 years ago

AliSoftware commented 3 years ago

I encountered the issue just today that SwiftGen crashed with fatal error when parsing a .strings file containing some "" strings in it. I then went to debug it and found it was because our lowerFirstWord filter was crashing on empty strings (startIndex == endIndex in those cases, which we didn't guard about as we used < not <= as a guard)

But then when I looked at the code (Filters+Strings.swift) I saw that it was already fixed in stable by @fortmarek when he was working on #127 – we just didn't add the entry for it given the main focus of #127 was on something else (for which it does have a CHANGELOG entry). But since #127 fixed 2 issues in one, we should also mention the fix there.

djbe commented 3 years ago

This also fixes https://github.com/SwiftGen/SwiftGen/issues/755 (I think), when we update SSK in SwiftGen.