search

SwiftKickMobile / SwiftMessages

A very flexible message bar for UIKit and SwiftUI.
MIT License
7.3k stars 742 forks source link

Swift 4.2 #225

Closed Michele404 closed 5 years ago

Michele404 commented 5 years ago

Update to 4.2 please

wtmoose commented 5 years ago

You can use the work/swift4.2 branch

rafsouzap commented 5 years ago

@wtmoose do you have plans to release this fix?

wtmoose commented 5 years ago

Of course!

wtmoose commented 5 years ago

@rafsouzap My intention was to release after wrapping up some other changes. But I can potentially release sooner. Is it causing a problem?

rafsouzap commented 5 years ago

@wtmoose We upgraded our app to Swift 4.2 and a few Pods we used were still incompatible, so we did the Pull Request. If it is not to disrupt your plans, we would be grateful if you could release these fixes.

wtmoose commented 5 years ago

I have a Swift 4.2 test project that happily runs SwiftMessages 5.0.1 via CocoaPods. So I didn't anticipate compatibility issues. Can you elaborate on what you mean by incompatible?

Michele404 commented 5 years ago

Yes, make an update to Swift 4.2 in the main branch please

wtmoose commented 5 years ago

What is the actual issue?

rafsouzap commented 5 years ago

@wtmoose I'm gonna configure Podfile to use SwiftMessages in Swift 4.0. Don't worry! Yesterday was crazy and I didn't remember it! 👍

wtmoose commented 5 years ago

OK guys, I went ahead and released 5.0.2 with Swift 4.2.

wtmoose commented 5 years ago

Please note this change broke builds for projects still using Swift 4.1 (see #229). So I reconfigured the versioning and you'll need to update to 6.0.0.