search

SwiftKickMobile / SwiftMessages

A very flexible message bar for UIKit and SwiftUI.
MIT License
7.33k stars 747 forks source link

Swift 5 support? #296

Closed OscarGorog closed 5 years ago

OscarGorog commented 5 years ago

Could you please add Swift 5 support?

Thanks in advance!

wtmoose commented 5 years ago

Is the 4.2 version not working with Swift 5?

OscarGorog commented 5 years ago

It is, but it would be great if it was compiling with Swift 5

appupfr commented 5 years ago

Yep there are just some warnings but the app still work correctly for me ;)

IceFloe commented 5 years ago

It would be nice to convert it to Swift 5

wtmoose commented 5 years ago

See work/swift5. It will be released soon.

OscarGorog commented 5 years ago

Great!

Coeur commented 5 years ago

@OkiRules

Add this in your Podfile:

pre_install do |installer|
    installer.analysis_result.specifications.each do |s|
        s.swift_version = '5.0'
    end
end

And all your swift pods will build for Swift 5.

OscarGorog commented 5 years ago

Thanks this is really useful!

Thanks, Oscar On 4 Apr 2019, 3:06 PM +1100, Antoine Cœur notifications@github.com, wrote:

@OkiRules At this in your Podfile: pre_install do |installer| installer.analysis_result.specifications.each do |s| s.swift_version = '5.0' end end And all your swift pods will build for Swift 5. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

vorb commented 5 years ago

And what should carthage-users do?

Thanks in advance!

Coeur commented 5 years ago

@vorb the same; living in Carthage shouldn't be a problem.

Or you could check the doc and add this in your Cartfile:

github "SwiftKickMobile/SwiftMessages" "work/swift5"
CedricSoubrie commented 5 years ago

Do you plan to merge work/swift5 branch into master soon ? And by the way : this library is AMAZINGLY good !!!

wtmoose commented 5 years ago

Yep, I do. Thanks!