SwiftKickMobile / SwiftMessages

A very flexible message bar for UIKit and SwiftUI.
MIT License
7.33k stars 747 forks source link

Memory Leak Tied To Presenter.swift #298

Closed abrpatel closed 5 years ago

abrpatel commented 5 years ago
Screen Shot 2019-04-09 at 6 48 03 PM

Shows up when the view is presented using a segue

class SwiftMessagesTopSegue: SwiftMessagesSegue {
    override public  init(identifier: String?, source: UIViewController, destination: UIViewController) {
        super.init(identifier: identifier, source: source, destination: destination)
        configure(layout: .topCard)

        super.interactiveHide = false
        super.dimMode = .gray(interactive: false)
    }
}

Would appreciate any suggestions on how to fix it.

wtmoose commented 5 years ago

The segue intentionally retains itself until you dismiss the view controller in order remain the transitioning delegate for dismissal.

abrpatel commented 5 years ago

Got it. Thanks!