search

SwiftKickMobile / SwiftMessages

A very flexible message bar for UIKit and SwiftUI.
MIT License
7.31k stars 743 forks source link

Inserted a conditional check to support Xcode 10.3 #350

Closed TizianoCoroneo closed 4 years ago

TizianoCoroneo commented 4 years ago

Xcode 10.3 complains that it doesn't know what a windowScene is. I added a directive to check for Swift 5.1 (the version included in Xcode 11), so that I can still compile the latest version in Xcode 10.3.

Tested in the demo app with Xcode 10.3 and Xcode 11.

wtmoose commented 4 years ago

7.0.0 supports Xcode 10. What is the argument for supporting old versions of Xcode going forward?

TizianoCoroneo commented 4 years ago

In my case, it is just to have a little more time to adopt Xcode 11 all over the place: the project I'm working on has a couple layout issues that are on Xcode 11 only, and my CI is still setup with Xcode 10.3. Having a little more flexibility in supporting 10.3 for a couple more months (maybe less) would be nice, especially if the only issue is the one in this PR that is solvable with a couple lines.

epastoor commented 4 years ago

I’m developing an app but have an older Mac that can’t run the latest Xcode. Having this flag would let me develop for a little while longer until I can afford a newer Mac running the latest Xcode.

wtmoose commented 4 years ago

@epastoor any reason why you don’t just use 7.0.0? I don’t see the point in doing another release when there’s already a workaround.

epastoor commented 4 years ago

6.0.2 works but 7.0.0 doesn’t work for me on Xcode 10.1.

I’m running high Sierra so I can’t upgrade Xcode any higher until I get a new machine.

wtmoose commented 4 years ago

@epastoor How does 7.0.0 not work for you? And how would this PR fix that?