SwiftKickMobile / SwiftMessages

A very flexible message bar for UIKit and SwiftUI.
MIT License
7.3k stars 742 forks source link

iOS13.1.3 compatibility issue #360

Closed woohyuknrg closed 4 years ago

woohyuknrg commented 4 years ago

when message show on my iPad Pro(11-inch), the whole UI doesn't respond to touch event; but it's OK on iOS13.1 simulator. The code below:

var config = SwiftMessages.defaultConfig config.presentationContext = .window(windowLevel: .normal) config.preferredStatusBarStyle = .lightContent config.duration = .seconds(seconds: 3)

SwiftMessages.show(config: config)

wtmoose commented 4 years ago

I wasn't able to reproduce this on my iPhone running 13.1 using the Explore section of the Demo app. Does the demo app not work for you?

Not much I can do without repro steps. If you can, send me a small sample app that doesn't work.

woohyuknrg commented 4 years ago

I run the SwiftMessages demo, has the same issue. I debug the source code, something wrong in PassthroughWindow: override func hitTest(_ point: CGPoint, with event: UIEvent?) -> UIView? { let view = super.hitTest(point, with: event) return view == self ? nil : view }

in iOS13.1.3 iPad Pro device, when message show, touch other place, it return view; but in iOS 13.1 simulator, it return nil, so I can touch anywhere.

woohyuknrg commented 4 years ago

You can reproduce on iPad Pro (11-inch) 13.1 simulator, or iPad Pro (12.9-inch) (3rd generation) 13.1 simulator. Works well on iPad Pro (9.7-inch) and iPad Pro (10.5-inch) 13.1, weird

wtmoose commented 4 years ago

Didn't you initially say it was OK in simulator but broken on device? Unfortunately, my iPad Pro is already on 13.2.

woohyuknrg commented 4 years ago

Before i only tested on 9.7 inch ipad pro simulator, it's OK on it. Now i test on all ipad pro simulator. OK on 9.7 and 10.5, have problem on 11 and 12.9. You can use 11 simulator to reproduce. Thanks

wtmoose commented 4 years ago

I'm on Xcode 13.2 beta, but I can't reproduce on iPad Pro 11 Simulator. Am I doing something wrong in the attached video?

iPad Pro 11 inch simulator demo.mp4.zip

woohyuknrg commented 4 years ago

Layout select Card, when message show, try to scroll the view below message view

wtmoose commented 4 years ago

Works for me.

iPad Pro 11 inch demo 2.mp4.zip

woohyuknrg commented 4 years ago

presentationContext set to normal level

wtmoose commented 4 years ago

OK my bad. Looks like iOS has started inserting its own views into the window's hierarchy.

Fix is on the head of master branch. I'll release soon.

woohyuknrg commented 4 years ago

Thank you very much

woohyuknrg commented 4 years ago

Hi, when does next version release?

wtmoose commented 4 years ago

As soon as I get some free time

ullstrm commented 4 years ago

Hi @wtmoose ! We have this problem aswell for our iPads! There seems to be a commit that should fix this on the master-branch. Is it ready for production? Will there be a release for this soon or are there other issues that needs fixing?

We will point our next release to the master branch for now to fix this. Are we in for some surprises? 😨

BinaryDennis commented 4 years ago

I would really appreciate it if this issue could be solved soon.

nectar1 commented 4 years ago

Up

d4rkd3v1l commented 4 years ago

Is there a timeline, when this will be released officially?

wtmoose commented 4 years ago

Included in 8.0.0 release