search

SwiftKickMobile / SwiftMessages

A very flexible message bar for UIKit and SwiftUI.
MIT License
7.24k stars 742 forks source link

Couple of fixes for xcode12 support #418

Closed ollitapa closed 3 years ago

ollitapa commented 3 years ago

Hi, sorry if I'm a bit too eager to get SPM-support for this project, but seemed like this branch missed some finishing touches. I had to fix the Bundle search function to match what the SPM generates to Bundle.module, because it was not finding the correct bundle on my app. Hopefully this supports CocoaPods/Carthage too, but I did not test it.

wtmoose commented 3 years ago

How about the adjustment I pushed? I tried to streamline the implementation a bit with a nested loop. And I returned a fallback value that matches the original implementation.

There's a separate issue with CocoaPods, but I can handle that after merging this into the feature branch.

ollitapa commented 3 years ago

Looks good! I can confirm it still works on my project. 👍

wtmoose commented 3 years ago

Great! Gonna merge this in and try to get a release out. Thanks for helping out