SwiftKickMobile / SwiftMessages

A very flexible message bar for UIKit and SwiftUI.
MIT License
7.24k stars 742 forks source link

Revert remove `windowScence` when hiding Toast view #438

Closed canhth closed 3 years ago

canhth commented 3 years ago

Description

wtmoose commented 3 years ago

According to the Apple documentation, it seems that setting windowScene = nil is correct.

https://developer.apple.com/documentation/uikit/uiwindow/3197962-windowscene https://developer.apple.com/documentation/uikit/uiwindowscene/3198091-windows

Furthermore, we were unable to reproduce your issue. To move forward with this, we need reproduction steps from you.

canhth commented 3 years ago

Hi @wtmoose,

Yes, I do understand that setting windowScene = nil is recommended by Apple. But I was able to reproduce this issue in iOS 14.1 and iOS 13.7. But seems it working fine in iOS 14.2 and 13.5...

So I assume this is the OS issue, and I suggest let's keep it for now.

If anyone facing the issue popup can not displayed --> We can redirect him to this: https://github.com/SwiftKickMobile/SwiftMessages/issues/429#issuecomment-730996540

wtmoose commented 3 years ago

@canhth sounds good. I'm going to close this for now. Thanks