Error layout in iphone12 pro max , Iphone11pro max, Xs max

[trinhson97]

layout Margin Additions displayed incorrectly on iphone12 pro max , Iphone11pro max and iphone Xs max.

[trinhson97]

Here is the code used:

[trinhson97]

    let success = MessageView.viewFromNib(layout: .cardView)
    success.configureTheme(.success)
    success.configureDropShadow()
    success.configureContent(title: "Success", body: "Something good happened!")
    success.button?.isHidden = false

    var successConfig = SwiftMessages.defaultConfig
    successConfig.presentationStyle = .top
    successConfig.presentationContext = .window(windowLevel: UIWindow.Level.normal)
    SwiftMessages.show(config: successConfig, view: success)

[trinhson97]

plz help me

[wtmoose]

What do you want it to look like?

[trinhson97]

I do want it to show as follows on screen ngang iphone xs max / iphone 11pro max :

[trinhson97]

can you help me

[canhth]

@wtmoose Let me clarify @trinhson97 question.

He's facing an issue in landscape mode with CardView on iPhone12 Pro Max, 11 Pro Max, Xs Max.

The CornerRoundingView frame should be updated when switching from Portrait to Landscape. In his case, the size still the same in both Portrait and Landscape mode. (It works with other iPhone type except Pro Max version)

For @trinhson97, please create a Pull Request if you do know how to fix this issue.

[Kamui-IOS]

i have the same problem.

[wtmoose]

@canhth thank you.

This is behaving as designed. The Max phones are regular size class in landscape. SwiftMessages uses a different layout in regular size class because developers didn't want the messages to span across the entire screen on iPad. The regular size class layout uses the view's intrinsic width with a maximum width of 500pt @ 950 priority.

My suggestion is that folks stick with the current behavior. If not, my thoughts are:

1. App developers can add a width or minimum width constraint to messageView.backgroundView to preserve a desired width.
2. SwiftMessages could add an option to always use the compact size class layout. However, the option would be apply to iPad and Max phones. If app developers only want to apply the option to Max phones, they would be responsible for implementing that logic.

I am in the middle of a major layout system revamp (check out the head of master) that will gives app developers straight forward and powerful control of the message layout, so I'm not very interested in taking on (2) as a tangent.

I'm open to suggestions.

[trinhson97]

@wtmoose thank you.

[trinhson97]

Can you help me demo?

[wtmoose]

@trinhson97 I don't understand what you're asking for

[wtmoose]

No reply...closing