search

SwiftKickMobile / SwiftMessages

A very flexible message bar for UIKit and SwiftUI.
MIT License
7.23k stars 741 forks source link

Xcode warnings in two swift files #534

Open ingopaulsen opened 7 months ago

ingopaulsen commented 7 months ago

Describe the bug I have received the following warnings in Xcode for SwiftMessages package (the numbers in brackets indicate the frequency):

BaseView.swift:

(2) Non-'@objc' instance method in extensions cannot be overridden; use 'public' instead

SwiftMessagesSegue.swift:

(1) Unnecessary check for 'iOS'; enclosing scope ensures guard will always be true

Environment (please complete the following information):

wtmoose commented 7 months ago

Thanks for calling my attention to this.

wtmoose commented 7 months ago

I wasn't able to reproduce the warnings, but I made some guesses and I think it should be good now. Could you pull down the head of master and let me know if the warnings are cleared up?