Add Privacy manifests file

SwiftKickMobile / SwiftMessages

A very flexible message bar for UIKit and SwiftUI.

MIT License

7.24k stars 741 forks source link

Add Privacy manifests file #546

Closed yasiraliraj closed 1 month ago

yasiraliraj commented 3 months ago

Hello Team,

I hope this message finds you well. I would like to draw your attention to an important update required by the App Store. Starting May 1, 2024, a privacy manifest will be mandatory for all apps. Given the ongoing development and support for your SDK, integrating this feature would be highly beneficial for ensuring compliance with the new App Store guidelines. This addition would greatly help developers like us in continuing to provide seamless services through our applications. We appreciate your attention to this matter and look forward to any updates you can provide.

Thank you for your continued support.

wtmoose commented 3 months ago

Are you up for submitting a PR?

yasiraliraj commented 3 months ago

@wtmoose Please check the PR: https://github.com/SwiftKickMobile/SwiftMessages/pull/547

SunZhiC commented 3 months ago

In the Apple forums, as indicated by a DTS engineer, it is recommended not adding an empty privacy manifest for no reason.

wtmoose commented 3 months ago

Interesting. That seems like a bad design. There’s no way to distinguish between a library that doesn’t need a manifest from one that does, but hasn’t added one yet.🤦‍♂️

mobru commented 2 months ago

@wtmoose do you intend to merge the above mentioned PR?

wtmoose commented 2 months ago

@mobru no. Did you read through the comments? I don’t see any case for adding it

mobru commented 2 months ago

@wtmoose I did, yeah. But looking a the proposed Privacy Manifest here, it looks like it would not be empty, and therefore required. Or am I misunderstanding something here (and sorry if so)?

wtmoose commented 2 months ago

@mobru my fault. I assumed it was empty and didn't read the file. I don't know where @yasiraliraj came up with those items. I can't think of any reason why the SwiftMessages manifest would not be empty. I'll give @yasiraliraj a chance to justify the changes and then close the PR.

wtmoose commented 2 months ago

@muruganandham I have no idea what “+1” means in the context of this conversation. Could you elaborate?

jznadams commented 2 months ago

FWIW this is the best explanation of the rules that we have found in the Apple documentation so far:

You need to include a privacy manifest file in your third-party SDK if it’s listed in “SDKs that require a privacy manifest and signature,” in Upcoming third-party SDK requirements.
Otherwise, include a privacy manifest file in your third-party SDK if it uses required reasons API, collects data about the person using apps that include the third-party SDK, enables the app to collect data about people using the app, or contacts tracking domains.

https://developer.apple.com/documentation/bundleresources/privacy_manifest_files

So sounds to me that if you don't use a required reasons API you don't need a manifest in the library.

wtmoose commented 2 months ago

@jznadams! Yeah we don’t need one