search

SwiftKit / CuckooGenerator

Generator of Mocks for Cuckoo
MIT License
20 stars 4 forks source link

Generated file header info issue #4

Closed a-voronov closed 8 years ago

a-voronov commented 8 years ago

Hi! I'm currently testing Cuckoo to see if it can fit my project. And the first issue I see is huge pull requests when working in a team.

This might happen because of writing file header for each generated token. https://github.com/SwiftKit/CuckooGenerator/blob/b25906805cd55f857eeb78a0b9776c36e96765c1/Source/CuckooGeneratorFramework/FileHeaderHandlers/FileHeaderHandler_r1.swift#L14

So each team member will create their own version of this file which might also cause conflicts. Otherwise this file should be ignored by git and generated by CI job runner.

But either way might be or not preferred by different groups of people.

What are your suggestions regarding this?

TadeasKriz commented 8 years ago

Hi, this generated file should be in your .gitignore and get generated before each tests. It will be changing as you will change protocols you want to mock, thus creating unnecessary commit changes.

Also, a new option will be added in the following days called --no-header which will disable the header generation.

TadeasKriz commented 8 years ago

Let me know if there is something we might do to make it more suitable for your project.

a-voronov commented 8 years ago

@TadeasKriz thanks! That would be really handy :) I'll create few more issues I've faced with while generating mocks for classes and will see what can be improved.

TadeasKriz commented 8 years ago

Thanks! Hopefully we can improve it. There are some limitations of Swift unfortunately.

TadeasKriz commented 8 years ago

Fixed in Cuckoo Generator 0.5.0.