search

SwiftKitz / Appz

📱 Launch external apps, and deeplink, with ease using Swift!
https://swiftkitz.github.io/
MIT License
1.18k stars 78 forks source link

Added iTunesU link #144

Closed Maryom closed 5 years ago

Maryom commented 5 years ago

Hey,

Can I pull a request to get rid of the following warning?

‘public’ modifier is redundant for enum declared in a public extension

Replace 'public ' with ''

By the way, I was not able to run the test until I select a team, that why Appz/Appz.xcodeproj/project.pbxproj has been modified.

Mazyod commented 5 years ago

This looks good, thanks! Regarding the warnings, maybe it will cause too many changes, maybe there is a way to easily fix them all at once.

Maryom commented 5 years ago

It’s totally fine with me to fix them manually because I enjoy doing things to Appz. Shall I do it?

Sent from my iPhone

On Mar 28, 2019, at 9:57 PM, Maz Jaleel notifications@github.com wrote:

This looks good, thanks! Regarding the warnings, maybe it will cause too many changes, maybe there is a way to easily fix them all at once.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Maryom commented 5 years ago

Or what about creating a python script that gets rid of this warning? It will use re to find public enum, then delete public. I think it’s easy inshallah I can do it if you like.

Sent from my iPhone

On Mar 28, 2019, at 10:02 PM, Mariam AlJamea mrm259@gmail.com wrote:

It’s totally fine with me to fix them manually because I enjoy doing things to Appz. Shall I do it?

Sent from my iPhone

On Mar 28, 2019, at 9:57 PM, Maz Jaleel notifications@github.com wrote:

This looks good, thanks! Regarding the warnings, maybe it will cause too many changes, maybe there is a way to easily fix them all at once.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Mazyod commented 5 years ago

Sure, go ahead