search

SwiftPackageIndex / SwiftPackageIndex-Server

The Swift Package Index is the place to find Swift packages!
https://swiftpackageindex.com
Apache License 2.0
567 stars 47 forks source link

Report doc related 500s as 404s #1825

Closed finestructure closed 2 years ago

finestructure commented 2 years ago

Example: https://rollbar.com/finestructure/SPI-server/items/74

finestructure commented 2 years ago

Ok, so the 500 was

CleanShot 2022-06-20 at 07 46 33@2x

which seems like an odd url to fail on.

But what Kingfisher is doing, is linking from our badge to the docs:

CleanShot 2022-06-20 at 07 47 52@2x

I'm guessing that this url got messed up while testing it and that's how we ended up receiving it.

I'll keep this open as a reminder to check if a 500 is what we want to raise here. I suspect we just want a 404 instead.

daveverwer commented 2 years ago

Just an extra bit of context, they tagged me the other day to ask about the included plugin. https://github.com/onevcat/Kingfisher/discussions/1952

It's still our problem as I'd not expect it to raise a 500 either, but I thought I'd mention the conversation.

finestructure commented 2 years ago

These are probably also attempts to access doc target links that have been configured specifically:

CleanShot 2022-06-21 at 10 30 32@2x

I've raised a PR to correct the config but we should still make those 404s so users can tell that they're accessing wrong urls.

finestructure commented 2 years ago

I believe this is fixed now by recent doccy-proxy changes.