SwiftPackageIndex / SwiftPackageIndex-Server

The Swift Package Index is the place to find Swift packages!
https://swiftpackageindex.com
Apache License 2.0
558 stars 46 forks source link

ipp-nio builds fail #2811

Closed finestructure closed 10 months ago

finestructure commented 10 months ago

all builds on SPM seem to fail because of this target with a custom path

        .executableTarget(
            name: "PrintPDF",
            dependencies: [
                .target(name: "IppClient"),
            ],
            path: "Examples/PrintPDF",
            exclude: ["hi_mom.pdf"]
        ),

error: 'spi-builder-workspace': invalid custom path 'Examples/PrintPDF' for target 'PrintPDF'

it works just fine locally - any tips?

Originally posted by @sliemeobn in https://github.com/SwiftPackageIndex/PackageList/issues/6115#issuecomment-1879057462

finestructure commented 10 months ago

I've just run the build locally and it works, so there must be something tripping up our build system.

daveverwer commented 10 months ago

I have just been looking into this, too, and I do get the error in every environment.

I tried it with our build environment tool, first and could reproduce the error, but I also get it from a simple checkout of the project and a swift build.

Screenshot 2024-01-05 at 19 32 00@2x

daveverwer commented 10 months ago

Ohh wait, that * is suspicious, and sure enough look what's happened.

Screenshot 2024-01-05 at 19 32 59@2x

I was running this after running our build tool and in the same checkout directory, so we must be deleting those two files with the build tool somehow, maybe as we're trying to clean up misleading xcodeproj files, which I know we do.

daveverwer commented 10 months ago

Thanks so much for the report, @sliemeobn. We'll need to figure this out and get it fixed.

finestructure commented 10 months ago

I mean what could possibly go wrong, right? 😆

https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/issues/2798#issuecomment-1867900493

sliemeobn commented 10 months ago

haha, sometimes things don't work in mysterious way, but rather crudely ; )

thanks for jumping on this so quickly! should I rename to folder for now, or is this something you are intent on fixing soon-ish?

PS: can't wait to hear about Sven joining the SSWG on the next podcast episode.

finestructure commented 10 months ago

Nothing to change on your end! It's a simple fix that I'll push out tomorrow, no worries :)

finestructure commented 10 months ago

Fixed here: https://gitlab.com/finestructure/swiftpackageindex-builder/-/merge_requests/246

Will re-trigger builds once deployed and close the issue once it's confirmed to work.

finestructure commented 10 months ago

Deployed and re-triggered:

CleanShot 2024-01-06 at 12 35 15@2x

It's odd that the visionOS build succeeds while iOS fails but we've made some progress at least. I'll close this for now, please re-open if these still look wrong to you in some way.

You can find the complete build command properly shown also for failing builds when you click through on individual builds. That should help verify that everything is in order.

Thanks again for the report, @sliemeobn !