SwiftPackageIndex / SwiftPackageIndex-Server

The Swift Package Index is the place to find Swift packages!
https://swiftpackageindex.com
Apache License 2.0
538 stars 42 forks source link

Incorrect package data for grpc-swift #3292

Closed glbrntt closed 3 weeks ago

glbrntt commented 4 weeks ago

Which package(s) are showing incorrect data?

Please explain what data is incorrect and what you expected to see

The last changes to the default branch (main) are showing as 21 days ago. It has had almost daily changes since then.

This is also reflected in the build status: the last builds for the default branch were on 24th July.

The Swift 6.0 beta builds are also showing as "Pending" and have done over the last few days when I've checked.

If the problem relates to the compatibility matrix, does it apply to specific builds?

N/a

Screenshots

N/a

Additional context

daveverwer commented 4 weeks ago

Thanks for the report, @glbrntt! This is likely a duplicate of #3290, which we found yesterday and is being investigated.

I'll leave this open but wanted to tag that issue so they can be related.

glbrntt commented 4 weeks ago

Ack. Thanks for the quick update Dave!

daveverwer commented 4 weeks ago

Actually I just realised I didn't address this point:

The Swift 6.0 beta builds are also showing as "Pending" and have done over the last few days when I've checked.

This is something different and it's intentional, or at least unavoidable for now.

We are running all packages past every iteration of the Swift 6 beta as part of our Ready for Swift 6 project. With the pace of Xcode releases during the summer, we almost always have a very large queue of pending builds as it takes more than 7 days for us to process everything for a new Xcode version.

This is unrelated to the analysis process that updates new versions and other metadata and is not affecting this issue.

glbrntt commented 4 weeks ago

How about Linux, would those builds be done at the same time as the Xcode builds?

Relatedly, is the documentation built at the same time? We added a new documentation target which is Swift 6 only whose docs haven't appeared yet.

finestructure commented 4 weeks ago

The Swift 6 Linux builds are scheduled at the same time, yes.

Note that your documentation is currently configured to be run with the latest release version of Swift (i.e. you're using the defaults). So if one of your targets requires Swift 6 then your documentation build on 5.10 will not be able to generate the docs for it.

I've opened a PR to move doc gen to Swift 6 here: https://github.com/grpc/grpc-swift/pull/2019

glbrntt commented 4 weeks ago

Oh that's great, thanks very much!

finestructure commented 3 weeks ago

FYI, the issue with this package wasn't #3298 but the fact that the Swift compiler in our previous base image wasn't able to dump the package manifest:

❯ dsh registry.gitlab.com/finestructure/spi-base:1.0.1
# bash
################################################################
#                                                              #
# Swift Nightly Docker Image                                   #
# Tag: swift-6.0-DEVELOPMENT-SNAPSHOT-2024-07-07-a             #
#                                                              #
################################################################
root@orbstack:/host# swift package dump-package
error: 'host': Invalid manifest (compiled with: ["/usr/bin/swiftc", "-vfsoverlay", "/tmp/TemporaryDirectory.1rZdxJ/vfs.yaml", "-L", "/usr/lib/swift/pm/ManifestAPI", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/usr/lib/swift/pm/ManifestAPI", "-swift-version", "6", "-I", "/usr/lib/swift/pm/ManifestAPI", "-package-description-version", "6.0.0", "/host/Package@swift-6.swift", "-o", "/tmp/TemporaryDirectory.pPmGaB/host-manifest"])
/host/Package@swift-6.swift:186:24: error: type 'SwiftSetting' has no member 'swiftLanguageMode'
 184 |       ),
 185 |       path: "Sources/GRPC",
 186 |       swiftSettings: [.swiftLanguageMode(.v5)]
     |                        `- error: type 'SwiftSetting' has no member 'swiftLanguageMode'
 187 |     )
 188 |   }

We've deployed a newer version earlier today which fixes this and the package should be updated with the next few hours.

I'll keep the issue open until we've verified it's working.

finestructure commented 3 weeks ago

This has now been updated:

CleanShot 2024-08-21 at 10 19 49@2x

glbrntt commented 3 weeks ago

Thanks Sven and Dave!