search

SwiftPackageIndex / SwiftPackageIndex-Server

The Swift Package Index is the place to find Swift packages!
https://swiftpackageindex.com
Apache License 2.0
554 stars 45 forks source link

change alert text color based on light/dark mode #3310

Closed rahafjrw closed 2 months ago

rahafjrw commented 2 months ago

Fix alert text to be white if in dark mode and black if in light mode Before:

before-darkmode

After:

after-darkmode
daveverwer commented 2 months ago

I have no idea why the test CI phase is failing here, especially when the last line of the log is:

Executed 767 tests, with 14 tests skipped and 0 failures (0 unexpected) in 200.656 (200.656) seconds

Could this be related to today's Linux test changes, @finestructure?

daveverwer commented 2 months ago

I just rebased this change on top of today's changes. Let's hope that fixes it.

daveverwer commented 2 months ago

The rebase did it 👍 Thanks so much for this @rahafjrw!