search

SwiftPeerLabSydney / CoffeeKit

Apache License 2.0
2 stars 3 forks source link

add localization, English and Korean, update show text to use this #10

Closed ncossor closed 4 years ago

ncossor commented 4 years ago

Hi all, can someone review this (you will have to trust YoungHoon on the korean string values, unless you speak Korean)

ncossor commented 4 years ago

re storing all of the LocalizedStringKey properties being 'centralized'.. swings and roundabouts. They must all be centralized in the Localizable.strings files anyway, but if we wanted to put them into (say) a single Swift file.. then

  1. we would need pretty formalized naming conventions, as the scope would be app wide
  2. the source file referencing the lookup key is disjoint with that common file

Given we only have a skeleton project at present, I suggest we come back and refactor along those lines once we have a more concrete app design and implementation, if we think it worthwhile.

ncossor commented 4 years ago

Hi @jimmyhoran I don't have access to merge("Merging is blocked"). Can you do this pls ? Thx

ncossor commented 4 years ago

thanks

hayounghoon commented 4 years ago

Nice one 👍 Maybe @hayounghoon can give it a review.

Yeah, we checked it together. Perfect!