SwiftcordApp / Swiftcord

A fully native Discord client for macOS built 100% in Swift!
https://swiftcordapp.github.io/Swiftcord/
GNU General Public License v3.0
1.85k stars 84 forks source link

Add folder display capability #110

Closed thegail closed 2 years ago

thegail commented 2 years ago

Pretty much what it sounds like. I matched the Discord UI very closely. Opportunities for future improvement/other notes:

I'm happy to DM screen recordings of my UI, in case you don't want to build my changes. I just don't really want the names of all the servers I'm in out in the wild.

cryptoAlgorithm commented 2 years ago

Nice PR! I have some suggestions though:

Animated mini-icons inside the folder preview always animate, not just on hover

Could this be made such that the icons only animate when the folder is hovered? That would improve performance I suppose.

Folders with only one server are displayed as single servers...the API is not very well structured in this area and I didn't find a way to differentiate between folders containing only one server and a server which isn't in a folder

Folders can actually have one server. It would be great if this case could be handled. However...

user_settings is a depreciated key and actually is already removed in the latest client versions. Swiftcord will also no longer receive this key in the future, so it would be prudent to move to the user_settings_proto (which I can help you adopt once this is merged)

cryptoAlgorithm commented 2 years ago

That commit contains major clean-ups and animates server icons on hover only