Closed thegail closed 2 years ago
Nice PR! I have some suggestions though:
Animated mini-icons inside the folder preview always animate, not just on hover
Could this be made such that the icons only animate when the folder is hovered? That would improve performance I suppose.
Folders with only one server are displayed as single servers...the API is not very well structured in this area and I didn't find a way to differentiate between folders containing only one server and a server which isn't in a folder
Folders can actually have one server. It would be great if this case could be handled. However...
user_settings
is a depreciated key and actually is already removed in the latest client versions. Swiftcord will also no longer receive this key in the future, so it would be prudent to move to the user_settings_proto
(which I can help you adopt once this is merged)
That commit contains major clean-ups and animates server icons on hover only
Pretty much what it sounds like. I matched the Discord UI very closely. Opportunities for future improvement/other notes:
ContentView.ServerListItem
andServerFolder.GuildFolder
. I didn't really know where to put these, since the project's current data model was unclear to me. This is something that could be rather painlessly fixed before merging.UserSettingsView.swift:35
andLoadingView.swift:37
). I did my best to make sure none of these changes got committed (including changes to Swiftcord.pbxproj). Because of this, I also don't know for sure whether my changes will build properly on a CI server or anyone else's machine, though I suspect they should.BetterImageView
, allowing a consumer to pass an(Image) -> Image
closure to make modifications to the original image. This is backwards compatible (at least for all the existing usages in the codebase) and an additive change.I'm happy to DM screen recordings of my UI, in case you don't want to build my changes. I just don't really want the names of all the servers I'm in out in the wild.