search

SwiftcordApp / Swiftcord

A fully native Discord client for macOS built 100% in Swift!
https://swiftcordapp.github.io/Swiftcord/
GNU General Public License v3.0
1.85k stars 84 forks source link

Channel visibility permissions are not respected #137

Closed glacialvitality closed 1 year ago

glacialvitality commented 1 year ago

Describe the Bug

Bug Description On a discord server, even if you don't have the perms to see certain channels on a given server, they can still be shown.

Actual Behaviour You can view the server's hidden channels, without perms.

Expected Behavior If you do not have permission to view the channel, it should be hidden

Reproducing the Bug

1... Open Swiftcord 2... Join a server (any discord server) 3... look at the channels list

Version

0.5.0

Category

Other

Relevant Log Output

No response

Screenshots

No response

Additional Info

No response

TerminalFi commented 1 year ago

@frozenfleris To be fair, Swiftcord is a client and it should be the servers responsibility to not disclose that information. I would say the bug lies with Discord. But.... I can see how the enduser might not want to see those servers

glacialvitality commented 1 year ago

Even if the channels are hidden on the regular discord client, it shows up on swiftcord's end. That's where I'm getting at with this.

TerminalFi commented 1 year ago

Sure, I get it.

TerminalFi commented 1 year ago

Even if the channels are hidden on the regular discord client, it shows up on swiftcord's end. That's where I'm getting at with this.

Btw, this would be a duplicate of #26

cryptoAlgorithm commented 1 year ago

Hi, thanks for reporting this. This isn't a bug, as Discord's API exposes all channels in the server, regardless if the user has permissions to view them. It's the responsibility of the client to hide those channels from the user, but that hasn't been implemented in Swiftcord yet.

cryptoAlgorithm commented 1 year ago

@frozenfleris Looks like that's clarified, I'll be closing this issue then :D