Bugfix and some new ui - Githubissues

SwiftcordApp / Swiftcord

A fully native Discord client for macOS built 100% in Swift!

https://swiftcordapp.github.io/Swiftcord/

GNU General Public License v3.0

1.85k stars 84 forks source link

Bugfix and some new ui #143

Closed 7408647n closed 1 year ago

7408647n commented 1 year ago

Fix a bug, why I can't build the app
Add the LogOut-button in settings
Add Appearance-menu in the new Settings-menu
Add Credits-menu in the new Settings-menu
Add Debug-menu in the new Settings-menu

cryptoAlgorithm commented 1 year ago

Hi, thanks for the contribution. Could you clarify regarding the bug, preventing you from building the app, that you fixed? I'd like to find out more as I cannot seem to find it from the changes you've made.

7408647n commented 1 year ago

Hi, thanks for the contribution. Could you clarify regarding the bug, preventing you from building the app, that you fixed? I'd like to find out more as I cannot seem to find it from the changes you've made.

Sure, in Swiftcord/Views/Message/EmbedView.swift, line 59 and Swiftcord/Views/User/Avatar/UserAvatarView.swift, line 90 I add the conditional cast operator

cryptoAlgorithm commented 1 year ago

Looks good! I'll be adding my own UI touch-ups to this commit as well, before merging it.

cryptoAlgorithm commented 1 year ago

@7408647n I've implemented many of these (but in a slightly different place and with different methods) in the settings branch, and as such I will be closing this PR (since there are now too many conflicts to merge).

Here are some screenshots of the implementations: (I have decided not to include a sign out button as that required duplicating a lot of existing code)

Appearance

Credits

Debug

7408647n commented 1 year ago

Has the logout button also been added in the settings? If not, I would fix the merge conflicts

cryptoAlgorithm commented 1 year ago

Nope, I decided not to add it because it leads to duplicate code. I might have to refactor the account manager to avoid that.